Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.cfg for tooling config. Starting with tox and pylint config. #1944

Merged
merged 3 commits into from Jun 13, 2020

Conversation

illume
Copy link
Member

@illume illume commented Jun 11, 2020

This is the PR from @mgorny continued #1932

Moves tox config into the setup.cfg

Since the test suite requires the package being installed, it is
non-trivial to run from a fresh git checkout.  Add a config file for tox
to take care of creating a virtualenv, installing the package
and testing it.
@MyreMylar
Copy link
Contributor

I think we may end up putting fixme into the pylint warning disable list as well, just because fixing TODO comments is generally a much larger job than fixing most (though not all) regular pylint warnings.

Either that or we could purge TODOs from the codebase and turn them into github issues instead?

@MyreMylar
Copy link
Contributor

MyreMylar commented Jun 12, 2020

Anyway, this seems like a great start and should be useful right away when linting.

@MyreMylar MyreMylar merged commit 586d04a into master Jun 13, 2020
@illume illume added buildconfig Code quality/robustness Code quality and resilience to changes labels Sep 13, 2020
@illume illume deleted the tox branch September 13, 2020 09:50
@illume illume changed the title setup.cfg for tooling config, starting with tox setup.cfg for tooling config. Starting with tox and pylint config. Sep 13, 2020
@illume illume added the tooling label Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
buildconfig Code quality/robustness Code quality and resilience to changes tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants