Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test failure without SDL_AUDIODRIVER set #1987

Merged
merged 1 commit into from Jul 2, 2020
Merged

Fix test failure without SDL_AUDIODRIVER set #1987

merged 1 commit into from Jul 2, 2020

Conversation

nthykier
Copy link
Contributor

Currently the tests fails if you have not set the SDL_AUDIODRIVER variable because of an os.environ[...] instead of os.environ.get(...).

@nthykier
Fix test failure without SDL_AUDIODRIVER set
fe0a002 
Signed-off-by: Niels Thykier <niels@thykier.net>
MyreMylar
MyreMylar approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MyreMylar MyreMylar merged commit 570a2e2 into master Jul 2, 2020
@illume illume deleted the fix-ci-without-environment branch September 14, 2020 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyreMylar MyreMylar MyreMylar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nthykier @MyreMylar