Allow setting several paths in PYGAME_EXTRA_BASE #1989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The variable is split on "`:`" and stored in an array called `extrabases`, which implies that several paths are valid. However, the loop just overwrites `incdirs` and `libdirs`, so only the last PATH in that variable is used.
|
This looks like a straight logic error to me - not much point iterating through a loop if you are just overwriting everything each cycle. @illume is likely the best person to confirm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variable is split on "
:" and is stored in an array calledextrabases, which implies that several paths are valid.However, the loop just overwrites
incdirsandlibdirs, so only the last PATH in that variable is used.