Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipenv: Fixed incorrect base class comparison (#1997) #2001

Merged
merged 1 commit into from Jul 10, 2020

Conversation

jtiai
Copy link
Contributor

@jtiai jtiai commented Jul 4, 2020

Fixes issue #1997 where comparison is made against wrong Command class.

@MyreMylar
Copy link
Contributor

Tried this locally on windows and didn't notice it breaking anything, everything still builds as it did before.

Under what circumstances was this causing an error - the issue doesn't make it clear?

@jtiai
Copy link
Contributor Author

jtiai commented Jul 4, 2020

Sorry forgot to add original error:

When trying to invoke setup.py:

$ python setup.py --help
Traceback (most recent call last):
  File "setup.py", line 616, in <module>
    class WinBuildExt(build_ext):
  File "setup.py", line 510, in decorator
    assert issubclass(command, Command)
AssertionError

Same error appeared when trying to install pygame from sources.

@MyreMylar
Copy link
Contributor

Hmm, I don't get this error on windows as far as I can tell. Perhaps it depends on a specific python version?

@MyreMylar MyreMylar changed the title Fixed incorrect base class comparison (#1997) Pipenv: Fixed incorrect base class comparison (#1997) Jul 5, 2020
@MyreMylar
Copy link
Contributor

Added Pipenv to the title so we can find this again if we get any more reports/related issues.

Copy link
Contributor

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solves a problem with pipenv and does no harm elsewhere. 👍

@MyreMylar MyreMylar linked an issue Jul 9, 2020 that may be closed by this pull request
@MyreMylar MyreMylar merged commit 4b53a69 into pygame:master Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In setup.py add_command decorator is broken
3 participants