Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added unit test for pygame.cursors.compile #2012

Merged
merged 3 commits into from Jul 30, 2020
Merged

Added unit test for pygame.cursors.compile #2012

merged 3 commits into from Jul 30, 2020

Conversation

codescientist703
Copy link
Contributor

@codescientist703 codescientist703 commented Jul 11, 2020 •
edited

This adds unit test for this issue #1761.

@codescientist703 codescientist703 mentioned this pull request Jul 11, 2020
Closed
MyreMylar
MyreMylar suggested changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works locally, just needs some small changes to work on CI.

test/cursors_test.py Outdated Show resolved Hide resolved
@codescientist703
Copy link
Contributor Author

Hi, I have done the changes as you requested. Now it is passing all the checks.

MyreMylar
MyreMylar approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MyreMylar MyreMylar linked an issue Jul 16, 2020 that may be closed by this pull request
Add unit test: cursors.compile() #1761
Closed
@MyreMylar MyreMylar merged commit 799c1cd into pygame:master Jul 30, 2020
@illume illume added the cursors pygame.cursors label Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyreMylar MyreMylar MyreMylar approved these changes

Assignees
No one assigned
Labels
cursors pygame.cursors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add unit test: cursors.compile()
3 participants
@codescientist703 @MyreMylar @illume