Fix OOB access in math.Vector swizzle; add '0' and '1' swizzles #2024
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2023.
This adds bounds checks on swizzles like
Vector2().xyz
.What I actually dived into this code for was to add swizzles with the digits
0
and1
. I can't easily make the two changes independent now so it's one PR.These will be useful to prepare homogenous coordinates for affine transforms by matrix multiplication. Here is a matrix representing a 2x scale + (3, -1) translation:
Given that the intended usage would be
.xy1
,.xyz1
or.xy01
, it's not really a disadvantage that we can't syntactically write.10yx
or something strange.