Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mouse.pyi@set_system_cursor type hints #2103

Merged
merged 1 commit into from Sep 20, 2020
Merged

Fix mouse.pyi@set_system_cursor type hints #2103

merged 1 commit into from Sep 20, 2020

Conversation

McSinyx
Copy link
Contributor

@McSinyx McSinyx commented Sep 20, 2020

This fixes the regression introduced by 3251c83, which causes mypy to complain:

.../site-packages/pygame/mouse.pyi:22: error: invalid syntax

MightyJosip
MightyJosip approved these changes Sep 20, 2020
View reviewed changes
Copy link
Contributor

@MightyJosip MightyJosip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍. This is great notice/change. I would have merged it, but since AppVeyor has some problems with downloading dependencies I will leave it for now. But it should definitely be merged.

@McSinyx
Copy link
Contributor Author

McSinyx commented Sep 20, 2020

Thanks for the prompt review! It seems that there was some 3rd party server outage at the time. Let me try to trigger a rerun.

@McSinyx McSinyx closed this Sep 20, 2020
@McSinyx McSinyx reopened this Sep 20, 2020
@MightyJosip
Copy link
Contributor

Thanks 👍

@MightyJosip MightyJosip merged commit d7a8b73 into pygame:master Sep 20, 2020
@McSinyx McSinyx deleted the pyi-set-system-cursor branch September 20, 2020 11:45
@illume illume added mouse pygame.mouse types Type hint checking related tasks labels Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MightyJosip MightyJosip MightyJosip approved these changes

Assignees
No one assigned
Labels
mouse pygame.mouse types Type hint checking related tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@McSinyx @MightyJosip @illume