Improve MacOS icon #2858
Improve MacOS icon #2858
Conversation
|
I actually think that perhaps the best way to get this tested on a wide range of macs is to merge it in and release it. On the one hand the icon quality is not a show stopping issue, on the other almost everyone who uses pygame on mac will see it immediately so by releasing it we will likely get lots of feedback if it looks worse on some subset of macs. I'd certainly rather pygame 2 had a modern and approachable icon on relatively modern macs, and perhaps a slightly worse icon on really old macs (if that is the case). One of pygame's issues on the wider internet (sadly) is people seeing it as old fashioned and a pixelated, artefact-y icon likely reinforces that perception. |
ankith26
added
the
Awaiting Merge
|
I don't think this is very high risk, so I'm going to merge it in But if @TomSchimansky or @rethanon wanted to test this, the mac wheels for this branch are in https://github.com/pygame/pygame/actions/runs/1489122638 |
Starbuck5
added
Platform: MacOS
and removed
Awaiting Merge
Tested on my Intel MacBook Pro running python 3.10 and MacOS 12.0.1, working great, thanks. |
Fixes #2791
In 1.9.6, the icon looks like this:
In 2.0+, the icon looks like this:
After this patch, the icon looks like this:
I'm not 100% sure on this, but my hypothesis is that setting the window icon in SDL1 didn't set the icon on the dock, which is where the window icon should go on MacOS. So the pygame developers of the day put custom code into SDLmain_osx.m that would automatically put a logo on if it wasn't running as an app bundle. It used pygame_icon.tiff. Now, I believe that happens but it is instantly overwritten by the default icon that display.c sets.
The regression icon is the icon set by display.c. It is very pixelated, but that actually looks fine on Windows, since the logo field is much smaller than a space on the MacOS dock. So this PR just changes the default icon filename in display.c for MacOS. (And it adds an attribute for the colorkeying because it can't colorkey away black unconditionally now).
I deleted the outdated / unused logo svg and tiff files.
I also deleted the obsolete macosx.py / SDLmain_osx.m code path, although it is some cool code.
Thanks to @TomSchimansky for bringing up to Mac standard and putting the snake on a rounded corners white background, providing the image files for this PR.
On a side note: why do we have .icns and .ico files in src_py anyway? I updated this with the new icns, but it doesn't seem like it would be used anywhere.