Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored code to make file easier to read, understand, and maintain #4105

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JacobOSU
Copy link

@JacobOSU JacobOSU commented Dec 5, 2023

Split cursor class into subclasses
Changed code to use subclasses
Removed deletion of methods
Changed variable names to use snakecase
Changed variable names to be more descriptive
Refactored load_xbm function to rid of duplicate code

Changed code to use subclasses
Removed deletion of methods
Changed variable names to use snakecase
Changed variable names to be more descriptive
Refactored load_xbm function to rid of duplicate code
Copy link

@Shidoengie Shidoengie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The subclass split was rather unecesserary and imo bad, everything else is alright

@illume illume closed this Apr 14, 2024
@illume illume reopened this Apr 14, 2024
@illume
Copy link
Member

illume commented Jun 17, 2024

Hello. Thanks for this, it's a good idea.

Looks like there are some test failures though.

Do you want to continue this? If so, it would be best to make a change and commit to smaller parts. Perhaps only change and commit one function at a time and push. That way the tests should run each time.

We now use the pre-commit tool for running code formatters/linters/etc.

python3 -m pip install pre-commit black ruff pylint
pre-commit run -a

To run the tests for cursor...

python3 -m pip install .
python3 test/cursors_test.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants