Refactored test from #3989 to work correctly and also apply to #4191 and fixed the bug being tested

[dillon-duff]

Fixed overflow bug in src_c/draw.c:draw_fillpoly from #4191 by changing y, miny, maxy, x1, y1, x2, y2 from int type to double. Uncommented and refactored a test that was previously meant to test the same bug

fixes #4191
fixes #3989

[illume]

Hi,

I have warnings as errors on CI.

There's some warnings as errors here: https://ci.appveyor.com/project/pygame/pygame/builds/49689982/job/m6kny35txym1rm4q#L792

src_c/draw.c(2359): error C2220: warning treated as error - no 'object' file generated
src_c/draw.c(2359): warning C4244: 'function': conversion from 'double' to 'int', possible loss of data
src_c/draw.c(2405): warning C4244: 'function': conversion from 'double' to 'int', possible loss of data
src_c/draw.c(2424): warning C4244: 'function': conversion from 'double' to 'int', possible loss of data

You could try adding an explicit cast to int (if it makes sense), and that should take care of the warnings.

[illume]

Cool, it looks like that warning issue is fixed.

Seems there's a clang-format issue left.

We recently started using pre-commit tool to check things before committing. https://pre-commit.com/#install

python -m pip install pre-commit
pre-commit install
pre-commit run --all-files

After you pre-commit install, it will run the checks at commit time. So the pre-commit run --all-files is not necessary.

[illume]

🎉🎈 thanks