Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup some test methods & test/sndarray_test.py #502

Merged
merged 3 commits into from Aug 23, 2018

Conversation

@e1000
Copy link

@e1000 e1000 commented Aug 23, 2018

Hello,

here some first cleanup branch on tests :

  • replace all occurences of failIf with assertFalse
  • replace some deprecated failUnlessEqual with standard assertEqual
  • rm obsolete if not arraytype ... in test/sndarray_test.py & rm a test on import

I first fancied, I could cleanup all tests methods, but that would be way to noisy.
2 tests of gfxdraw_test.py fail, they fail also on master, right ?

Once merged, we can check the test/sndarray_test.py in #496

@illume
Copy link
Member

@illume illume commented Aug 23, 2018

Thanks @e1000

Yeah, those are disabled so that the tests can pass on the CI.

@illume illume merged commit fa89c03 into pygame:master Aug 23, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@illume illume mentioned this pull request Oct 16, 2018
4 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants