Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PY_VERSION_HEX < 0x02070000 : cleanup #516

Merged
merged 4 commits into from Aug 31, 2018
Merged

Conversation

@e1000
Copy link

@e1000 e1000 commented Aug 31, 2018

trivial cleanup if I understand things right ...

@illume
Copy link
Member

@illume illume commented Aug 31, 2018

Soon things are going to be so tidy :)

Looks like there is a problem.
From the travis CI build log:

gcc -pthread -fno-strict-aliasing -g -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -fPIC -D_REENTRANT -DENABLE_NEWBUF=1 -I/usr/X11R6/include -I/usr/include/SDL -I/opt/python/2.7.14/include/python2.7 -c src_c/bufferproxy.c -o build/temp.linux-x86_64-2.7/src_c/bufferproxy.o
src_c/bufferproxy.c:638:6: error: expected expression before ‘getbufferproc’
     (getbufferproc)proxy_getbuffer,
      ^
src_c/bufferproxy.c:627:5: error: called object is not a function or function pointer
     0
     ^
src_c/bufferproxy.c:638:20: error: expected ‘}’ before ‘proxy_getbuffer’
     (getbufferproc)proxy_getbuffer,
                    ^
---
@e1000
Copy link
Author

@e1000 e1000 commented Aug 31, 2018

ah, I could reproduce it, it should be fixed by now. As for the tidiness, I think we can invite Sid some day, to play with the code ;-)

@illume
Copy link
Member

@illume illume commented Aug 31, 2018

Great, that fixed it :)

@illume illume merged commit 9e24832 into pygame:master Aug 31, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@illume illume mentioned this pull request Oct 16, 2018
4 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants