Mac fonts support using system_profiler #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated initsysfonts_darwin() to use the system_profiler command if fc-list is not found
Simplified system_profiler by utilizing several functions to do some of the processes. Also added checking if the executed command returns zero (success).
e1000
reviewed
Sep 16, 2018
src_py/sysfont.py
Outdated
| """Gets the specified element iterable""" | ||
|
|
||
| #Get the ElementTree object from the xml string | ||
| mac_fonts_xml_tree = ET.fromstring(xml_string) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
src_py/sysfont.py
Outdated
| tag_content_list = [content for content in tag_text if content.strip() != ""] | ||
|
|
||
| return tag_content_list | ||
|
|
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
No need to process all the text into a list with this method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced fc-list with system_profiler as requested in this issue: #179