Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve message on failed imports & cleanup (fix #541) #546

Merged
merged 5 commits into from Oct 9, 2018
Merged

Improve message on failed imports & cleanup (fix #541) #546

merged 5 commits into from Oct 9, 2018

Conversation

e1000
Copy link

@e1000 e1000 commented Oct 2, 2018 •
edited

Fix and cleanup failing pygame modules (edit : fixes #541) :

  • Capture the import exception at MissingModule.__init__
  • _failed_import variable usage
  • cleanup MissingModule class

@e1000 e1000 changed the title Improve message on failed imports & cleanup Improve message on failed imports & cleanup (fix #541) Oct 2, 2018
@illume
Copy link
Member

illume commented Oct 9, 2018

Very nice :)

@illume illume merged commit 73a6390 into pygame:master Oct 9, 2018
@illume illume mentioned this pull request Oct 16, 2018
Closed
4 tasks
@Sharparam Sharparam mentioned this pull request Aug 27, 2019
Closed
@bendavis78
Copy link

bendavis78 commented Jan 3, 2020 •
edited

This PR breaks #413. Was it necessary to remove the _import_failed variables?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No proper error message showing up when there's an import error
3 participants
@e1000 @illume @bendavis78