Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve message on failed imports & cleanup (fix #541) #546

Merged
merged 5 commits into from Oct 9, 2018

Conversation

Projects
None yet
2 participants
@e1000
Copy link

e1000 commented Oct 2, 2018

Fix and cleanup failing pygame modules (edit : fixes #541) :

  • Capture the import exception at MissingModule.__init__
  • _failed_import variable usage
  • cleanup MissingModule class

@e1000 e1000 changed the title Improve message on failed imports & cleanup Improve message on failed imports & cleanup (fix #541) Oct 2, 2018

@illume

This comment has been minimized.

Copy link
Member

illume commented Oct 9, 2018

Very nice :)

@illume illume merged commit 73a6390 into pygame:master Oct 9, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illume illume referenced this pull request Oct 16, 2018

Closed

1.9.5 release notes. #561

4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.