Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bugs in surface.blits #571

Merged
merged 1 commit into from Oct 23, 2018
Merged

fix bugs in surface.blits #571

merged 1 commit into from Oct 23, 2018

Conversation

@LiquidFenrir
Copy link
Contributor

@LiquidFenrir LiquidFenrir commented Oct 18, 2018

Hello! If you're in the official (at least it's linked on the official pygame website?) discord, you could see I got segfaults when trying to use surface.blits with 4 args per tuple, dug a little and found these glaring at me. Untested because I don't have the environment to compile it, but logically it should fix them.

Thanks for your time, this library is incredible

off by one error when getting the args
wouldn't get the area rect if the special_flags were present
@illume
Copy link
Member

@illume illume commented Oct 23, 2018

Thanks for this!

Yes, it looks like the tests don't cover this case. Oops.

@illume illume merged commit 242d519 into pygame:master Oct 23, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dlon dlon mentioned this pull request Mar 23, 2019
4 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants