Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overlap_mask() making incorrect mask #783

merged 1 commit into from Feb 1, 2019


Copy link

@charlesej charlesej commented Jan 31, 2019

This update fixes the issue with overlap_mask() producing incorrect masks.

Overview of changes:

  • Fixed the issue with overlap_mask() producing incorrect masks. The upper bits were being set incorrectly in some cases.
  • Added a new test method to test overlap_mask() with a variety of offsets.
  • Removed the @unittest.expectedFailure decorator as the test is now passing.

System details:

  • os: windows 10 (64bit)
  • python: 3.7.2 (64bit)
  • pygame: 1.9.5.dev0 (SDL: 1.2.15) at 8711f71

Resolves #410.

@illume illume merged commit 591f23e into pygame:master Feb 1, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
@charlesej charlesej deleted the charlesej:fix-overlap-mask branch Feb 1, 2019
@dlon dlon mentioned this pull request Mar 23, 2019
4 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants