Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pump parameter and keyword arguments to some event functions #805

Merged
merged 6 commits into from Feb 17, 2019
Merged

Conversation

@dlon
Copy link
Member

@dlon dlon commented Feb 8, 2019

  • Adds keyword arguments: event.clear(eventtype=None, pump=True), event.clear(eventtype=None, pump=True), and event.get(eventtype=None, pump=True).
  • pump can be set to False to safely use these functions in other threads (w/ GIL). This works for both SDL1 and SDL2.

Related: #794.

docs/reST/ref/event.rst Outdated Show resolved Hide resolved
src_c/event.c Outdated Show resolved Hide resolved
@illume
Copy link
Member

@illume illume commented Feb 12, 2019

Oops. I made some conflicts by merging in the other branch.

@dlon dlon merged commit 4243c0b into master Feb 17, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dlon dlon deleted the event-pump branch Feb 17, 2019
@dlon dlon mentioned this pull request Mar 23, 2019
4 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants