Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LayeredDirty's inconsistent use of its source rect #928

Merged
merged 1 commit into from Mar 24, 2019

Conversation

@charlesej
Copy link
Contributor

@charlesej charlesej commented Mar 23, 2019

This update changes LayeredDirty so the use of its source_rect is consistent.

Overview of changes:

  • Changed LayeredDirty so the use of its source_rect is consistent
  • Removed @unittest.expectedFailure decorator from the now passing test

System details:

  • os: windows 10 (64bit)
  • python: 3.7.2 (64bit) and 2.7.10 (64bit)
  • pygame: 1.9.5.dev0 (SDL: 1.2.15) at 883dacc

Related: #899, #900, #919.

@illume
illume approved these changes Mar 24, 2019
@illume
Copy link
Member

@illume illume commented Mar 24, 2019

Very good :)

@illume illume merged commit f7675fc into pygame:master Mar 24, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@charlesej charlesej deleted the charlesej:fix-source-rect-issue branch Mar 24, 2019
@illume illume mentioned this pull request Mar 31, 2019
4 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants