Fix issue #31 : 'long' does not exist in python3 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance of getting this reviewed please? If you need any more information, do not hesitate to ask. |
|
Sean, Vladimir, if you are currently short-staffed or focusing on other projects, maybe you would like help maintaining pygeobuf? |
|
Ping? |
sgillies
approved these changes
Jun 30, 2017
|
@jlaine apologies. I lost track of the fact that I'd been pinged to review this. |
|
Awesome thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #31 .
On a side note : this error did not crop up in the testsuite, because it does not exercise the implicit final "else" in the if/elif block. Adding a "null" (None) value to test/fixtures/props.json does trigger the error reported in #31.