-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add get_z ufunc #175
Merged
Merged
ENH: Add get_z ufunc #175
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f851242
ENH: Add get_z ufunc
jorisvandenbossche 298fa1c
Merge remote-tracking branch 'upstream/master' into get-z
jorisvandenbossche f64d9c7
get_z requires GEOS 3.7
jorisvandenbossche a14d6eb
add changelog
jorisvandenbossche 0c2035f
Merge remote-tracking branch 'upstream/master' into get-z
jorisvandenbossche 0461fca
clean-up + add note on min GEOS version
jorisvandenbossche File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -699,6 +699,19 @@ static int GetY(void *context, void *a, double *b) { | |
} | ||
} | ||
static void *get_y_data[1] = {GetY}; | ||
static int GetZ(void *context, void *a, double *b) { | ||
char typ = GEOSGeomTypeId_r(context, a); | ||
if (typ != 0) { | ||
*(double *)b = NPY_NAN; | ||
return 1; | ||
// } else if (GEOSGeom_getCoordinateDimension_r(context, a) != 3) { | ||
// *(double *)b = NPY_NAN; | ||
// return 0; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Need to clean this up depending on what we decide regarding returning nan vs raising an error |
||
} else { | ||
return GEOSGeomGetZ_r(context, a, b); | ||
} | ||
} | ||
static void *get_z_data[1] = {GetZ}; | ||
static void *area_data[1] = {GEOSArea_r}; | ||
static void *length_data[1] = {GEOSLength_r}; | ||
typedef int FuncGEOS_Y_d(void *context, void *a, double *b); | ||
|
@@ -1896,6 +1909,7 @@ int init_ufuncs(PyObject *m, PyObject *d) | |
|
||
DEFINE_Y_d (get_x); | ||
DEFINE_Y_d (get_y); | ||
DEFINE_Y_d (get_z); | ||
DEFINE_Y_d (area); | ||
DEFINE_Y_d (length); | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you note that this function is only available for geos>=3.7.0?