Fix line shader to avoid artifacts on straight lines #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almarklein
commented
Jan 5, 2023
|
Wow you guys are amazing! This fix works 🎉 Using the lines in these massive visualizations which were impossible with pyqtgraph 😄 line_fixed-2023-01-05_16.55.48.mp4 |
Korijn
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #419
Changes how the 5th vertex position is calculated, avoiding the generate case when the current point is exactly on the line between the two neighboring points (i.e. the line is straight). Also fixes the calculation of the angle so it can actually be used to decide on what side the "inside" is.
I visually confirmed that the line examples still produce correct results, and that the artifacts in #419 are gone.