Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change event time_stamp unit to seconds #742

Merged
merged 3 commits into from
Apr 25, 2024
Merged

Conversation

panxinmiao
Copy link
Contributor

@panxinmiao panxinmiao commented Apr 25, 2024

Closes #741.

API changes

  • Event "time_stamp" attribute changed from ms to seconds.

@panxinmiao panxinmiao requested a review from Korijn as a code owner April 25, 2024 14:20
@panxinmiao panxinmiao changed the title Fix event time_stamp Change event time_stamp unit to seconds Apr 25, 2024
Copy link
Collaborator

@Korijn Korijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@Korijn Korijn merged commit 9b3f5b6 into pygfx:main Apr 25, 2024
12 checks passed
@almarklein
Copy link
Collaborator

Introduces some backwards incompatibility for people that use the timestamps. Added a note in the top post, so we (probably) won't forget to add it to the release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double click event triggers only once
3 participants