WxWgpuWindow object has no attribute 'add_event_handler'

[cansik]

At least on MacOS, it seems that the WxWgpuWindow integration seems not to work. The example found here can not be run because of the following issue:

Traceback (most recent call last):
  File "/pyfx_image_viewer.py", line 11, in <module>
    canvas = WgpuCanvas()
  File "/venv/lib/python3.9/site-packages/wgpu/gui/wx.py", line 146, in __init__
    self._subwidget.add_event_handler(weakbind(self.handle_event), "*")
AttributeError: 'WxWgpuWindow' object has no attribute 'add_event_handler'

Versions:

• pygfx 0.1.18
• wgpu 0.15.0
• wxpython 4.2.1
• python 3.9.18

[Korijn]

Are you experienced with Wx? We're looking for maintainers for the wx backend.

[cansik]

It seems that the issue is related to the wgpu-py package. I am not even sure why this has been added (7dcd6ae), it seems to it has been added to wx and qt as well. Do you have more information about that line?

If this line is removed, there is another issue inside the timer start. At the moment 0 can be passed as wait time, even that is not an allowed value. Adding a max(1, ...) and converting to int solves this issue:

  def _request_draw(self):
      # Despite the FPS limiting the delayed call to refresh solves
      # that drawing only happens when the mouse is down, see pygfx/pygfx#209.
      if not self._request_draw_timer.IsRunning():
          self._request_draw_timer.Start(
              max(1, int(self._get_draw_wait_time() * 1000)), wx.TIMER_ONE_SHOT
          )

@Korijn I wouldn't call myself experienced, however, I would like to have pygfx support in wx.

[Korijn]

Indeed the gui backends are implemented in wgpu-py. You'd have to fix this there. I'll transfer the issue for you.

[cansik]

@Korijn I have created a PR to fix this in wgpu and another one which updates the wx example in pygfx. Would be great if you could have a look.