Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable F821, and a few codegen improvements #144

Merged
merged 11 commits into from
Apr 2, 2021
Merged

Enable F821, and a few codegen improvements #144

merged 11 commits into from
Apr 2, 2021

Conversation

almarklein
Copy link
Collaborator

The flake8 F821 undefined name was ignored, because function annotations and pyshader.

  • The IDL parser is now able to fully resolve types to either a Python builtin, or a GPU-class/flag/enum/struct.
  • The codegen can therefore now generate annotations that are "valid".
  • The structs module is therefore now also much cleaner.
  • Where we use pyshader (in tests and examples) we still ignore this error.
  • Improvement to codegen regarding ordering decorators and comments.

wgpu/base.py Outdated Show resolved Hide resolved
@almarklein almarklein merged commit c7e3e40 into main Apr 2, 2021
@almarklein almarklein deleted the f821 branch April 2, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants