-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cibuildwheel #194
Cibuildwheel #194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
One question: where is it defined what build are made exactly? E.g. why does it not try to build linux_arm64. Or phrased differently, what would we change when we have wgpu-native builds for linux_arm_64?
See To build more linux archs you would set the |
Ah, so now it's using the default, which is x86_64 and i686 for Linux? |
Indeed! |
Simplified the sdist-build job and fixed a bug in the publish job where it didn't depend on the sdist-build job. Should be good to go! |
This PR leverages cibuildwheel to handle creation of wheels, including macos arm64.
Checks 1 box in #136 as this works around the missing Apple Silicon runners on CI.
This PR makes the build configuration PEP517 and pypa/build compatible, allowing the
pip wheel
command to be used by cibuildwheel.So to summarize, all the following commands are now legal:
python setup.py bdist_wheel
pip wheel --no-deps .
cibuildwheel --platform <plat>
Build artifacts: