Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cibuildwheel #194

Merged
merged 10 commits into from
Oct 8, 2021
Merged

Cibuildwheel #194

merged 10 commits into from
Oct 8, 2021

Conversation

Korijn
Copy link
Collaborator

@Korijn Korijn commented Oct 7, 2021

This PR leverages cibuildwheel to handle creation of wheels, including macos arm64.

Checks 1 box in #136 as this works around the missing Apple Silicon runners on CI.

This PR makes the build configuration PEP517 and pypa/build compatible, allowing the pip wheel command to be used by cibuildwheel.

So to summarize, all the following commands are now legal:

  • python setup.py bdist_wheel
  • pip wheel --no-deps .
  • cibuildwheel --platform <plat>

Build artifacts:

image

@Korijn Korijn marked this pull request as ready for review October 7, 2021 11:16
@Korijn Korijn mentioned this pull request Oct 7, 2021
7 tasks
Copy link
Collaborator

@almarklein almarklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

One question: where is it defined what build are made exactly? E.g. why does it not try to build linux_arm64. Or phrased differently, what would we change when we have wgpu-native builds for linux_arm_64?

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@Korijn
Copy link
Collaborator Author

Korijn commented Oct 7, 2021

Nice!

One question: where is it defined what build are made exactly? E.g. why does it not try to build linux_arm64. Or phrased differently, what would we change when we have wgpu-native builds for linux_arm_64?

See pyproject.toml, I've used the build and archs options. Related docs: https://cibuildwheel.readthedocs.io/en/stable/options/#build-skip

To build more linux archs you would set the archs option for linux in pyproject.toml, as I've done for mac.

@almarklein
Copy link
Collaborator

Ah, so now it's using the default, which is x86_64 and i686 for Linux?

@Korijn
Copy link
Collaborator Author

Korijn commented Oct 7, 2021

Ah, so now it's using the default, which is x86_64 and i686 for Linux?

Indeed!

@Korijn
Copy link
Collaborator Author

Korijn commented Oct 8, 2021

Simplified the sdist-build job and fixed a bug in the publish job where it didn't depend on the sdist-build job. Should be good to go!

@Korijn Korijn mentioned this pull request Oct 8, 2021
@almarklein almarklein merged commit ae2356a into main Oct 8, 2021
@almarklein almarklein deleted the cibuildwheel branch October 8, 2021 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants