Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cffi dependency to 1.15.0rc2 to fix issue with macOS arm #196

Merged
merged 4 commits into from
Oct 8, 2021

Conversation

berendkleinhaneveld
Copy link
Contributor

Resolve problems with cffi wheels for M1 (see #136 and #190 ).

@marcdownie Could you check to see if you still get the MemoryError or not (#136 (comment))? I don't have a conda setup on my machine so I can't verify this.

@Korijn
Copy link
Collaborator

Korijn commented Oct 8, 2021

For some reason this breaks the pyinstaller tests? :/

@Korijn
Copy link
Collaborator

Korijn commented Oct 8, 2021

Can you try replacing python setup.py develop with pip install -e .? I think that should trigger pip to uninstall the old version of cffi before installing the newer version.

It seems python setup.py develop doesn't involve pip at all.

@Korijn
Copy link
Collaborator

Korijn commented Oct 8, 2021

LGTM!

@berendkleinhaneveld
Copy link
Contributor Author

I installed glfw with brew and after that I could run the glfw examples without getting the MemoryError, so I can't replicate it.

@berendkleinhaneveld berendkleinhaneveld merged commit 720fce4 into main Oct 8, 2021
@berendkleinhaneveld berendkleinhaneveld deleted the update-cffi branch October 8, 2021 14:29
@Korijn Korijn mentioned this pull request Oct 8, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants