-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add utility to run compute shaders, and add tests for it #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almarklein
commented
Jan 21, 2020
almarklein
commented
Jan 21, 2020
almarklein
commented
Jan 21, 2020
For now, let's just add an option to skip the tests and merge so we can continue with development, and use #47 to track the problem. |
…ectly covers part of our API)
…med to _coreutils
Ready for final checkup. Changes since last review:
|
I'm not too familiar with ctypes but it looks good! |
Korijn
approved these changes
Jan 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compute_with_buffers()
utility function.After this makes it into a release,
python-shader
could use it to better validate the compiler.At this this point this is blocked by #47: the added test can't run on CI. If there is no quick solution for it, I proposewe disable the test on CI, so that we can at least run it locally.