Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New wgpu native #506

Merged
merged 2 commits into from
Jun 13, 2024
Merged

New wgpu native #506

merged 2 commits into from
Jun 13, 2024

Conversation

almarklein
Copy link
Collaborator

@almarklein almarklein commented May 23, 2024

Preparations

  • Wrap up outstanding PR's.
  • Release wgpu-py.

Upstream

Update to latest IDL

Not now.

Update to latest wgpu-native

  • Run python download-wgpu-native.py --version xx to download the latest webgpu.h and DLL.
  • Run python codegen to apply the automatic patches to the code.
  • It may be necessary to tweak the hparser.py to adjust to new formatting.
  • Diff the report for new differences to take into account.
  • Diff wgpu_native/_api.py to get an idea of what structs and functions have changed.
  • Go through all FIXME comments that were added in _api.py:
    * Apply any necessary changes.
    * Remove the FIXME comment if no further action is needed, or turn into a TODO for later.
  • Run python codegen again to validate that all is well. Repeat the steps above if necessary.
  • Make sure that the tests run and provide full coverage.
  • Make sure that the examples all work.
  • Make sure that pygfx works (again).
  • Update release notes for changes in behavior.

Wrapping up

  • Update pygfx. (no need)
  • Release new wgpu-py.
  • Release new pygfx, maybe.

@almarklein almarklein requested a review from Korijn as a code owner May 23, 2024 14:47
@almarklein almarklein marked this pull request as draft May 23, 2024 14:47
@almarklein
Copy link
Collaborator Author

Made this because I hoped it fixed pygfx/pygfx#763. It did not. Can update nonetheless.

@almarklein almarklein force-pushed the update-wgpu branch 2 times, most recently from 7089171 to f77f6c9 Compare June 12, 2024 07:55
@almarklein almarklein marked this pull request as ready for review June 12, 2024 07:57
@almarklein
Copy link
Collaborator Author

Ready. Let's bump it.

@almarklein
Copy link
Collaborator Author

@Korijn can this one get approval too?

@almarklein almarklein merged commit 9914545 into main Jun 13, 2024
20 checks passed
@almarklein almarklein deleted the update-wgpu branch June 13, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants