Allow passing canvas to request_adapter #83
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
request_adapter
in wgpu-native now supports passing the surface id, so that we can make sure that the returned adapter is actually compatible with that (or such type of) surface.I considered a few options to express this in the API, and this seems to be the most straightforward, even though it makes the API deviate from WebGPU somewhat (because in WebGPU the browser knows the surface id, so the user does not need pass it). Made it a required argument, so that it's obvious when it's set to None.
It's quite liberating that in an API that's low-level, we can afford to be a bit verbose at times :)