We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tl;dr the rest of the codebase accepts RGBA, but Caret hasn't been updated yet
Other areas of the codebase (shapes, gui, the rest of text) have been updated to accept Tuple[int, int, int, int] for colors. However, Caret has not:
Tuple[int, int, int, int]
Caret
pyglet/pyglet/text/caret.py
Lines 70 to 91 in 5bc0f80
If there's no technical reason blocking it, can we add it?
The text was updated successfully, but these errors were encountered:
Sure, that's valid. How about doing it the same way as Shapes, so we can support both RGB and RGBA, not breaking backwards compatibility?
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
tl;dr the rest of the codebase accepts RGBA, but Caret hasn't been updated yet
Other areas of the codebase (shapes, gui, the rest of text) have been updated to accept
Tuple[int, int, int, int]
for colors. However,Caret
has not:pyglet/pyglet/text/caret.py
Lines 70 to 91 in 5bc0f80
If there's no technical reason blocking it, can we add it?
The text was updated successfully, but these errors were encountered: