Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RGBA support to Caret #806

Merged
merged 20 commits into from
Apr 12, 2023
Merged

Conversation

pushfoo
Copy link
Contributor

@pushfoo pushfoo commented Apr 9, 2023

Closes #805.

Summary:

  • Add RGBA color support with the same behavior as Shapes
  • Move color behavior fixtures to the top-level unit test conftest.py & improves on them
  • Add tests for new RGBA color support in Caret
  • Add warning to docstring about strange color setter behavior shortly after window init

benmoran56
benmoran56 previously approved these changes Apr 10, 2023
@pushfoo pushfoo marked this pull request as ready for review April 11, 2023 10:10
@pushfoo pushfoo requested a review from benmoran56 April 11, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add RGBA support to Caret
2 participants