Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

on_mouse_scroll uses wrong parameters #904

Closed
zhengxyz123 opened this issue Jul 28, 2023 · 2 comments
Closed

on_mouse_scroll uses wrong parameters #904

zhengxyz123 opened this issue Jul 28, 2023 · 2 comments
Assignees
@benmoran56
Labels
bug Something isn't working

Comments

@zhengxyz123
Copy link
Contributor

The Frame and WidgetBase(and one widget) use the wrong parameters compared to Window.

The first two must act like the window, so they should use

def on_mouse_scroll(self, x, y, scroll_x, scroll_y):
    ...
@zhengxyz123 zhengxyz123 added the bug Something isn't working label Jul 28, 2023
@benmoran56
Copy link
Member

That's a good catch. Thanks for opening the issue.

@benmoran56 benmoran56 self-assigned this Jul 28, 2023
benmoran56 added a commit that referenced this issue Jul 28, 2023
@benmoran56
gui: fix on_mouse_scroll handler argument names #904
3c493f7
@benmoran56
Copy link
Member

Fixed in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benmoran56 benmoran56

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benmoran56 @zhengxyz123