Add Type Hints to image/__init__.py

[gran4]

I wanted to fix #787 so I type hinted it.

[gran4]

empty

[benmoran56]

Most of this looks good, but there are a large amount of inaccuracies. I have made comments for those that I have found, but there could be more.

[benmoran56]

Pardon the delay, but it's quite challenging to review this PR. There are many mistakes, and it takes a lot of time to review manually. I added a few more comments for issues that I found. There are also several issues that appear all throughout, but I did not comment them.

1. Many of the classmethods are wrong. cls should be the actual object of the class that will be returned, but it's often shown as AbstractImage. This might pass a type checker, but it's returning the subclass is more accurate.

2. There are many unnecessary docstring breaks. All docstrings should start on the same line as the triple quotes for compactness. For example:

def function():
    """This is preferred

def function():
    """
    Not this

3. Many functions are unnecessarily wrapped. pyglet adheres to PEP8, with the exception of a relaxed line length limit. It's acceptable (and preferred) to allow function definitions to reach 100 (or up to 110) columns, rather than splitting to multiple lines.

[gran4]

Ok. Are you the only one reviewing pyglet PRs.

…

On Wed, May 24, 2023 at 2:03 AM Benjamin ***@***.***> wrote: Pardon the delay, but it's quite challenging to review this PR. There are many mistakes, and it takes a lot of time to review manually. I added a few more comments for issues that I found. There are also several issues that appear all throughout, but I did not comment them. 1. Many of the classmethods are wrong. cls should be the actual object of the class that will be returned, but it's often shown as AbstractImage. This might pass a type checker, but it's returning the subclass is more accurate. 2. There are many unnecessary docstring breaks. All docstrings should start on the same line as the triple quotes for compactness. For example: def function(): """This is preferreddef function(): """ Not this 1. Many functions are unnecessarily wrapped. pyglet adheres to PEP8, with the exception of a relaxed line length limit. It's acceptable (and preferred) to allow function definitions to reach 100 (or up to 110) columns, rather than splitting to multiple lines. — Reply to this email directly, view it on GitHub <#818 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATHLIH7HGS5QINI6F3FVYDDXHXFFZANCNFSM6AAAAAAXRGF2NM> . You are receiving this because you authored the thread.Message ID: ***@***.***>