Add type hints to shapes #857
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+58
to
+63
| from typing import ( | ||
| Union, | ||
| Optional, | ||
| Tuple, | ||
| List | ||
| ) |
There was a problem hiding this comment.
how about just from typing import Union, Optional, Tuple, List
There was a problem hiding this comment.
As imports get longer, it is better to put them on separate line. I do not actually know how many are needed to start putting them on separate lines though.(needs more input)
| @@ -1395,7 +1424,7 @@ def border_color(self, values): | |||
| self._update_color() | |||
|
|
|||
| @property | |||
| def color(self): | |||
| def color(self) -> Tuple[int, int, int, int]: | |||
There was a problem hiding this comment.
how about add a type named color rgba
|
In the ellipse class, segments is not in the docstrings. Is this a bug @benmoran56 or is this something that just needs to be updated? |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.