Fix some use-after-frees and memory leak in the wmf decoder

[Square789]

This says "some" cause the video part is intentionally using a use-after-free to expose the frame.
In any case, the primary reason for this PR is to fix the jumping leak from #926 stemming from the _source_reader not being released, now that the other one turned out to be a Python bug.

[caffeinepills]

This causes audio to skip and crackle on my machine. The reason buffers and samples were not a local variable was because the data can get GC'd during playback in some drivers if not stored somewhere, and has to be freed up after it's been played, not before.

[Square789]

Thanks for the quick report, caught me by surprise; it works fine for me with both DirectSound and XAudio2.
Even before, the audio data was copied via memmove, there's no reasonable way the playback mechanism could still have any kind of access to the IMFBuffer/Samples. Maybe i'm releasing the imf_sample too early, the MS docs don't mention anything explicitly, but maybe it deletes its buffers even if they still have references.

[caffeinepills]

I updated to the latest with sample being freed last, and it seems to have fixed the crackling for me. (Windows 11, Xaudio2, ogg/mp3 testing)

[caffeinepills]

Also, the video portion of WMF can probably just be removed in the future as it shouldn't be used anymore.

[benmoran56]

Shall we merge this for now, and then strip out the video parts in the development branch?

[Square789]

I don't really know what the status with the wmf decoder's video section is. I could not get it to play any video in the first place. The _debug at

pyglet/pyglet/media/codecs/wmf.py

Line 576 in 45fc7d1

assert _debug('WMFVideoDecoder: Found Video Stream')

is triggered, but then this bit:

pyglet/pyglet/media/codecs/wmf.py

Lines 590 to 593 in 45fc7d1

	try:
	self._source_reader.SetCurrentMediaType(self._video_stream_index, None, uncompressed_mt)
	except OSError as err: # Can't decode codec.
	raise DecodeException(err) from None

always fails and reports [WinError -1072875852] The data specified for the media type is invalid, inconsistent, or not supported by this object for a variety of videos in different formats i've thrown at it.
I was focusing this PR on fixing issues in the audio section only; i feel any changes regarding the video part are kinda out of scope for this PR

[pushfoo]

I'm still hesitant about tearing out the WMF video decoding. If we can get MP4 to work and establish a baseline for the video stream across Mac & Windows, we'd have a 0-pyglet video equivalent to MP3. That could be a significant decrease in download size.

[caffeinepills]

always fails and reports [WinError -1072875852] The data specified for the media type is invalid, inconsistent, or not supported by this object for a variety of videos in different formats i've thrown at it.
I was focusing this PR on fixing issues in the audio section only; i feel any changes regarding the video part are kinda out of scope for this PR

The formats are somewhat limited I believe. Video stuff can be removed at a later date.

I'm still hesitant about tearing out the WMF video decoding. If we can get MP4 to work and establish a baseline for the video stream across Mac & Windows, we'd have a 0-pyglet video equivalent to MP3. That could be a significant decrease in download size.

Unfortunately with WMF it's not hardware accelerated without DirectX and I am not quite up to the task of creating a DirectX-OpenGL link just to make video work for whatever formats it supports when FFmpeg does it all better.

We can leave the video stuff for another PR later down the road.