Improvements to the Savi lexer #2102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous example shows the old usage of the testing framework. Now the example reflects the current usage/API of that framework.
Prior to this change, every underscore/private identifier in Savi code was being highlighted as if it were a class name. After this change, only those whose first letter is uppercase will be highlighted as such, which is the correct behavior.
Now the Savi lexer can tokenize string interpolation inside strings, which is a new feature added to Savi since the last time this lexer was updated.
jeanas
reviewed
Apr 3, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has several improvements to the Savi lexer:
See individual commits for details.
Each commit is a self-contained unit of change.