New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenSCAD lexer #2449
Add OpenSCAD lexer #2449
Conversation
Fixed linter complaints, at least locally :-). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks OK, here are some more or less minor comments to address though.
Co-authored-by: Jean Abou-Samra <jean@abou-samra.fr>
Thanks for the review, good catches. Yes, some of pieces embarrassingly look non logical or even weird. I will resolve the things. |
Ping? |
Sorry for the delay, things went a bit unplanned last week. It is in my list. I am going to resolve all the comments today or tomorrow. |
I have updated the things. |
No worries; I was just trying to make sure of the status (we have a number of open PRs where I am not sure whether the author consciously abandoned them or just forgot about them…). I'll review this again. |
Co-authored-by: Jean Abou-Samra <jean@abou-samra.fr>
Thanks for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good! Just waiting for CI to complete.
Add OpenSCAD lexer
Ref. #886