Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenSCAD lexer #2449

Merged
merged 5 commits into from Jun 14, 2023
Merged

Add OpenSCAD lexer #2449

merged 5 commits into from Jun 14, 2023

Conversation

nantipov
Copy link
Contributor

@nantipov nantipov commented Jun 4, 2023

Add OpenSCAD lexer
Ref. #886

@jeanas jeanas self-assigned this Jun 4, 2023
@nantipov
Copy link
Contributor Author

nantipov commented Jun 4, 2023

Fixed linter complaints, at least locally :-).

Copy link
Contributor

@jeanas jeanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks OK, here are some more or less minor comments to address though.

pygments/lexers/openscad.py Show resolved Hide resolved
pygments/lexers/openscad.py Show resolved Hide resolved
pygments/lexers/openscad.py Outdated Show resolved Hide resolved
pygments/lexers/openscad.py Outdated Show resolved Hide resolved
pygments/lexers/openscad.py Outdated Show resolved Hide resolved
pygments/lexers/openscad.py Outdated Show resolved Hide resolved
pygments/lexers/openscad.py Outdated Show resolved Hide resolved
pygments/lexers/openscad.py Outdated Show resolved Hide resolved
pygments/lexers/openscad.py Outdated Show resolved Hide resolved
pygments/lexers/openscad.py Outdated Show resolved Hide resolved
Co-authored-by: Jean Abou-Samra <jean@abou-samra.fr>
@nantipov
Copy link
Contributor Author

nantipov commented Jun 6, 2023

Generally looks OK, here are some more or less minor comments to address though.

Thanks for the review, good catches. Yes, some of pieces embarrassingly look non logical or even weird.
This is adaptation of the locally backed lexer.

I will resolve the things.

@jeanas
Copy link
Contributor

jeanas commented Jun 12, 2023

Ping?

@nantipov
Copy link
Contributor Author

nantipov commented Jun 12, 2023

Ping?

Sorry for the delay, things went a bit unplanned last week.

It is in my list. I am going to resolve all the comments today or tomorrow.

@nantipov
Copy link
Contributor Author

I have updated the things.

@jeanas
Copy link
Contributor

jeanas commented Jun 14, 2023

Ping?

Sorry for the delay, things went a bit unplanned last week.

No worries; I was just trying to make sure of the status (we have a number of open PRs where I am not sure whether the author consciously abandoned them or just forgot about them…).

I'll review this again.

pygments/lexers/openscad.py Outdated Show resolved Hide resolved
pygments/lexers/openscad.py Outdated Show resolved Hide resolved
pygments/lexers/openscad.py Outdated Show resolved Hide resolved
pygments/lexers/openscad.py Outdated Show resolved Hide resolved
@nantipov
Copy link
Contributor Author

Thanks for the review.
I have updated things.

Copy link
Contributor

@jeanas jeanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! Just waiting for CI to complete.

@jeanas jeanas merged commit e1c0f6d into pygments:master Jun 14, 2023
15 checks passed
@Anteru Anteru added this to the 2.16.0 milestone Aug 5, 2023
@Anteru Anteru added the A-lexing area: changes to individual lexers label Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-lexing area: changes to individual lexers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants