Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#291: Adjustments for linux resolver #292

Merged
merged 3 commits into from
Feb 4, 2021
Merged

#291: Adjustments for linux resolver #292

merged 3 commits into from
Feb 4, 2021

Conversation

fubarhouse
Copy link
Collaborator

In the example of Debian and Debian-based systems the Linux resolver does not work.

In testing on Arch, the new configuration works in the exact same way with the added benefit of the configuration structured exactly like the mac one - one configuration file per resolver.

This one resolves #291

Signed-off-by: Karl Hepworth <karl.hepworth@gmail.com>
Signed-off-by: Karl Hepworth <karl.hepworth@gmail.com>
service/library/setup.go Outdated Show resolved Hide resolved
@twardnw
Copy link
Contributor

twardnw commented Feb 4, 2021

I was able to test on Ubuntu 20.04, this works as expected

@tobybellwood
Copy link
Collaborator

agreed, LGTM

nice work!

Signed-off-by: Karl Hepworth <karl.hepworth@gmail.com>
@fubarhouse fubarhouse merged commit 5b51ce9 into main Feb 4, 2021
fubarhouse added a commit that referenced this pull request Feb 4, 2021
* #291 - adjust resolver on linux
* #291 - adjust typo
* Add new line suffix to linux resolver
@fubarhouse fubarhouse deleted the issue/291 branch March 6, 2021 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Incorrect resolver file for Ubuntu 20
3 participants