Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference to cairocffi unclear #262

Closed
page200 opened this issue Mar 16, 2022 · 3 comments
Closed

Reference to cairocffi unclear #262

page200 opened this issue Mar 16, 2022 · 3 comments
Labels

Comments

@page200
Copy link

page200 commented Mar 16, 2022

An comma in the README after a nonessential clause might be missing, distorting the meaning. Without the comma, the sentence syntax can be parsed as follows:

"If Pycairo is not what you need, have a look at cairocffi, which is an API compatible package using {{{cffi or Qahirah}}}, which is using ctypes and provides a more "pythonic" API with less focus on matching the cairo C API."

By adding a comma after "cffi":

"If Pycairo is not what you need, have a look at {{{cairocffi, which is an API compatible package using cffi}}}, or {{{Qahirah, which is using ctypes and provides a more "pythonic" API with less focus on matching the cairo C API.}}}"

Is that what is meant? Better yet, make a bullet list of the alternatives.

Moreover, it is unclear what the pros and cons of using cffi are, i.e. the pros and cons of cairocffi. In what cases may Pycairo be "not what you need" as the README says, whereas cairocffi is?

Thanks!

@lazka
Copy link
Member

lazka commented Nov 21, 2022

An comma in the README after a nonessential clause might be missing, distorting the meaning. Without the comma, the sentence syntax can be parsed as follows:

"If Pycairo is not what you need, have a look at cairocffi, which is an API compatible package using {{{cffi or Qahirah}}}, which is using ctypes and provides a more "pythonic" API with less focus on matching the cairo C API."

By adding a comma after "cffi":

"If Pycairo is not what you need, have a look at {{{cairocffi, which is an API compatible package using cffi}}}, or {{{Qahirah, which is using ctypes and provides a more "pythonic" API with less focus on matching the cairo C API.}}}"

Is that what is meant? Better yet, make a bullet list of the alternatives.

yes, thanks.

Moreover, it is unclear what the pros and cons of using cffi are, i.e. the pros and cons of cairocffi. In what cases may Pycairo be "not what you need" as the README says, whereas cairocffi is?

Fair point. I didn't want to compare them too much back then as I was biased. I'll try to make this clearer.

lazka added a commit that referenced this issue Nov 22, 2022
and make it a list with a bitmore details for why you'd want to consider them.

See #262
@lazka
Copy link
Member

lazka commented Nov 28, 2022

I've moved the text to the bottom of https://pycairo.readthedocs.io/en/latest/ now and rewrote it.

Feedback welcome

@lazka lazka added the needinfo label Nov 28, 2022
@stuaxo
Copy link
Collaborator

stuaxo commented Nov 29, 2022

Reads clearly to me, explains what it is + the benefits. 👍

@lazka lazka closed this as completed Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants