Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup.py: Somehow warn on bdist_wheel #83

Closed
lazka opened this issue Nov 28, 2017 · 1 comment
Closed

setup.py: Somehow warn on bdist_wheel #83

lazka opened this issue Nov 28, 2017 · 1 comment
Labels
enhancement

Comments

@lazka
Copy link
Member

lazka commented Nov 28, 2017

See NixOS/nixpkgs#32034 (comment)

When building a wheel for pycairo the pkgconfig file can contain the wrong prefix when installed

We could print a big warning after bdist_wheel finishes.
@lazka lazka closed this as completed in c031144 Nov 28, 2017
lazka added a commit that referenced this issue Nov 28, 2017
@lazka
Merge pull request #84 from lazka/bdist-wheel-warning
3c937b0 
setup.py: Show a warning regarding pkgconfig paths when running bdist_wheel. Fixes #83
lazka added a commit that referenced this issue Jan 1, 2018
@lazka
setup.py: Don't include the pkg-config file when building wheels. See #…
75044e6 
…83

This just creates problems, so just skip it.
@lazka
Copy link
Member Author

lazka commented Jan 1, 2018

I've decided to not include .pc files when building wheels as that likely generates problems with pip caching wheels and installing the same wheel to different environments.

@jtojnar you need to patch away that check in 75044e6 if you continue to use wheels for the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lazka