Move header into the package and add a get_include() function #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazka
force-pushed
the
get-include
branch
5 times, most recently
from
271b1b2
to
ae6cef1
Compare
…gobject#92 Pycairo installs .pc files which work quite well where the default prefix is used, like with distro packaging etc. In virtualenvs the pkg-config look up path needs to be set manually, and in pip wheels are involved, where we had to disable installing .pc files as they can get reused for a different prefix. To make it easier for other python modules to use the C API introduce a new function get_include() (similar ot what numpy has) which returns the include path that needs to be passed to the compiler. Since we can't really get the old header install path from the module (one could walk up the tree and look for matching files, but that's ugly) move the header file into the package itself, so that the path can be dervived from the package path. To prevent code from breaking which hardcodes the old include path install a header to the old location which includes the new header location.
lazka
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.