Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The warnings module expects a string, not bytes. #104

Merged
merged 1 commit into from Oct 27, 2016

Conversation

jonathanslenders
Copy link
Contributor

Otherwise, it crashes with "TypeError: can't use a string pattern on a
bytes-like object" when the errors list is not empty.

Otherwise, it crashes with "TypeError: can't use a string pattern on a
bytes-like object" when the errors list is not empty.
@coveralls
Copy link

coveralls commented Sep 30, 2016

Coverage Status

Coverage remained the same at 81.075% when pulling 8a6fc5d on jonathanslenders:warnings-bug into 28b9e9d on pygraphviz:master.

@mmarkov
Copy link
Contributor

mmarkov commented Oct 1, 2016

Looks good, definitely should solve the issue.

Copy link
Contributor

@mmarkov mmarkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hagberg hagberg merged commit 7fdb3a3 into pygraphviz:master Oct 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants