Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ResourceWarnings under Python 3.6 #152

Closed
wants to merge 2 commits into from
Closed

Fix ResourceWarnings under Python 3.6 #152

wants to merge 2 commits into from

Conversation

Byvire
Copy link
Contributor

@Byvire Byvire commented Apr 13, 2018

Issue #151
FYI, some of the tests don't pass for me, even without this change.

@Byvire
Copy link
Contributor Author

Byvire commented Apr 13, 2018

Ooh, my bad. I forgot Python 2 compatibility was a thing. subprocess.Popen didn't support the context manager protocol until Python 3.2.

@Byvire Byvire closed this Apr 13, 2018
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 80.998% when pulling 3b296ff on Byvire:master into 36120f2 on pygraphviz:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 80.998% when pulling 3b296ff on Byvire:master into 36120f2 on pygraphviz:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 80.998% when pulling 3b296ff on Byvire:master into 36120f2 on pygraphviz:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Byvire @coveralls