Fix graphviz_wrap.c for Pypy3 #183
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
027d11d ("Fix graphviz_wrap.c _wrap_agwrite for Pypy3") covers _wrap_agwrite, but leaves the same problem in _wrap_agread because it fixes code in the file generated by swig. The commit introduces additional disturbance due using newer swig version: 3.0.8 instead of 3.0.7. Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
4 similar comments
|
I believe this change is no longer needed after #230 was merged. no check for version before 3.0 is needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
027d11d ("Fix graphviz_wrap.c _wrap_agwrite for Pypy3") covers _wrap_agwrite,
but leaves the same problem in _wrap_agread because it fixes code in
the file generated by swig.
The commit introduces additional disturbance due using newer swig version:
3.0.8 instead of 3.0.7.
Fixes #177.