Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: I added method .decode(utf-8) after calling C-func of getting… #203

Merged
merged 4 commits into from Aug 2, 2020

Conversation

n-piipel
Copy link

… encoding from handle of .dot file

This is a decision for issue #202

Надёжин Н.А added 2 commits August 24, 2019 00:05
…ting encoding from handle of .dot file, if the result is bytes type
@coveralls
Copy link

coveralls commented Aug 26, 2019

Coverage Status

Coverage remained the same at 82.001% when pulling bc0518d on n-piipel:bugfix_issue#202 into 37208d1 on pygraphviz:master.

@jarrodmillman jarrodmillman added this to the 1.6 milestone Jul 8, 2020
@jarrodmillman jarrodmillman marked this pull request as draft July 18, 2020 01:56
@dschult dschult marked this pull request as ready for review August 2, 2020 06:20
Copy link
Contributor

@dschult dschult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the right solution. If it is not bytes, make it bytes.
Thanks!

@dschult dschult merged commit a298104 into pygraphviz:master Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants