Implement changes to AGraph.clear() to handle custom attributes #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Thanks. |
hagberg
added a commit
that referenced
this pull request
Aug 31, 2015
Implement changes to AGraph.clear() to handle custom attributes
|
Hi Aric, I found one more issue and fixed it in one more pull request. with kind regards, On Mon, Aug 31, 2015 at 2:42 PM, Aric Hagberg notifications@github.com
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue #65
Actually node_attr is dictionary of all possible node attributes and it should not be cleared during graph clear. It will be cleared automatically during handle close.