Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the new plugin: basketball #187

Merged
merged 6 commits into from Feb 16, 2023
Merged

Conversation

kefthymic
Copy link
Contributor

Description

I finished the basketball plugin. I tested my code using the test_plugin_script.

@CLAassistant
Copy link

CLAassistant commented Feb 8, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ kefthymic
❌ pre-commit-ci-lite[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

docs/source/Plugins/fun.rst Outdated Show resolved Hide resolved
@Abdur-rahmaanJ
Copy link
Member

Great PR else!

@Abdur-rahmaanJ
Copy link
Member

@MrTanoshii Please review

@Abdur-rahmaanJ
Copy link
Member

hey @kefthymic Can you add it on the README? Thanks!

@kefthymic
Copy link
Contributor Author

kefthymic commented Feb 16, 2023

Hello @Abdur-rahmaanJ . I added the plugin on the README. Is it ok?

Copy link
Member

@MrTanoshii MrTanoshii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a few formatting/style issues with main.py and README.md

Can you please do the following:

@MrTanoshii MrTanoshii added enhancement New feature or request plugin Related to honeybot plugins labels Feb 16, 2023
@kefthymic
Copy link
Contributor Author

@MrTanoshii I formatted the README using the https://codebeautify.org/markdown-formatter as you told me and also ran the command for the main.py. Is there anything I need to do?

@kefthymic kefthymic requested review from MrTanoshii and removed request for Abdur-rahmaanJ February 16, 2023 10:53
Copy link
Member

@MrTanoshii MrTanoshii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MrTanoshii MrTanoshii merged commit 10612a6 into pyhoneybot:master Feb 16, 2023
@MrTanoshii
Copy link
Member

Thank you once again!

There's nothing else to do, your plugin is now merged 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request plugin Related to honeybot plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants