improved structure and readability of main.py #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.Removed unnecessary import statements (import sys, import shutil, import getpass). 2.Encapsulated the code inside the BotCore class to provide better organization and encapsulation. 3.Replaced hardcoded configuration values with variables (self.server_url, self.port, self.name, etc.). 4.Utilized the os.path module for path-related operations instead of manually concatenating strings. 5.Updated the logging statements to use the logger instance. 6.Refactored the message_info method to handle exceptions and return a dictionary with all fields set to prevent None values. 7.Updated the methods method to return a dictionary of method references. 8.Added docstrings to functions and methods. 9.Fixed the indentation of the code to conform to Python style guidelines. 10.Replaced the print statements with logger statements for consistent logging. 11.Modified the load_plugins_from_folder method to handle different sources of plugin names (from configuration file or directory) and log errors appropriately. 12.Updated the load_plugins method to load plugins from the specified folders. 13.Refactored the run_plugins method to use the loaded plugins and pass the necessary arguments to the plugin's run method. 14.Renamed command_parser method to core_commands_parse for clarity. 15.Removed unused methods and variables (self.sp_command, self.core_plugins, pull). 16.Added missing exception handling in the quit method. 17.Cleaned up the code formatting and removed unnecessary comments.
MrTanoshii
added
enhancement
|
|
||
| """ | ||
| ONGOING REQUIREMENT/S | ||
| """ |
There was a problem hiding this comment.
@AnastasiosZyngiridis Why did you remove this section?
There was a problem hiding this comment.
@Abdur-rahmaanJ Sorry for the mistake. As they where ONGOING REQUIREMENT/S i didn't touch them and forgot to put them back in after i was done editing the rest of the code.
There was a problem hiding this comment.
@AnastasiosZyngiridis Just add them back, thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.Removed unnecessary import statements (import sys, import shutil, import getpass).
2.Encapsulated the code inside the BotCore class to provide better organization and encapsulation.
3.Replaced hardcoded configuration values with variables (self.server_url, self.port, self.name, etc.).
4.Utilized the os.path module for path-related operations instead of manually concatenating strings.
5.Updated the logging statements to use the logger instance.
6.Refactored the message_info method to handle exceptions and return a dictionary with all fields set to prevent None values.
7.Updated the methods method to return a dictionary of method references.
8.Added docstrings to functions and methods.
9.Fixed the indentation of the code to conform to Python style guidelines.
10.Replaced the print statements with logger statements for consistent logging.
11.Modified the load_plugins_from_folder method to handle different sources of plugin names (from configuration file or directory) and log errors appropriately.
12.Updated the load_plugins method to load plugins from the specified folders.
13.Refactored the run_plugins method to use the loaded plugins and pass the necessary arguments to the plugin's run method.
14.Renamed command_parser method to core_commands_parse for clarity.
15.Removed unused methods and variables (self.sp_command, self.core_plugins, pull).
16.Added missing exception handling in the quit method.
17.Cleaned up the code formatting and removed unnecessary comments.
Description
How Has This Been Tested?
Additional context
Add any other context or screenshots about the pull request here.
Checklist
README.mdCode of Conduct
By submitting this issue, you agree to follow our Code of Conduct