Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation #226

Merged
merged 2 commits into from
Jan 30, 2022
Merged

Annotation #226

merged 2 commits into from
Jan 30, 2022

Conversation

Oliver-1-1
Copy link
Contributor

This annotation could of saved me probably 1 hour. I thought the attach_callbacks would attach my back end callbacks that are set before in glfw. But I misunderstood it. A change to the argument name can be done aswell. Like attach_default_callbacks, or attach_pre_set_callbacks

Oliver-1-1 and others added 2 commits April 16, 2021 19:41
This annotation could of saved me probably 1 hour.  I thought the attach_callbacks would attach my back end callbacks that are set before in glfw. But I misunderstood it. A change to the argument name can be done aswell. Like attach_default_callbacks, or attach_pre_set_callbacks
@coveralls
Copy link

Coverage Status

Coverage remained the same at 55.95% when pulling 12ddc44 on Oliver-Dahlen:master into 480b4de on swistakm:master.

@KinoxKlark
Copy link
Member

I agree, this is a bit unclear and your annotation seems adequate. Thanks! This is unfortunately incompatible with older python versions such as 2.7 which is currently supported.

As mentioned by @swistakm in the last release note (https://github.com/swistakm/pyimgui/releases/tag/1.3.0), support of python version 2.7, 3.3, and 3.4 should be dropped in the next major release 2.0.0. Thus, this may need to wait until there.

@Oliver-1-1
Copy link
Contributor Author

Ah ok, I didn't realize the support for the newest python wasn't there. Keep up the great work tho.

@KinoxKlark KinoxKlark changed the base branch from master to dev/version-2.0 January 30, 2022 09:03
@KinoxKlark KinoxKlark merged commit e6f88f0 into pyimgui:dev/version-2.0 Jan 30, 2022
@KinoxKlark
Copy link
Member

Thanks!

@KinoxKlark KinoxKlark added the release pending Merged but still needs official release label Jan 30, 2022
@KinoxKlark KinoxKlark removed the release pending Merged but still needs official release label Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants