Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo and value / type switch error #275

Merged
merged 2 commits into from
Apr 21, 2022

Conversation

Willy-JL
Copy link
Contributor

@Willy-JL Willy-JL commented Apr 19, 2022

Was trying to do some more complex UIs and encountered a few bugs:

  • table_setup_scroll_freez() typo, should be table_setup_scroll_freeze()
  • is_popup_open() passes the str type instead of the label value to _bytes(), causing a crash
    This of course is a simple fix to both.

Copy link
Collaborator

@learn-more learn-more left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KinoxKlark KinoxKlark merged commit 573d2d6 into pyimgui:dev/version-2.0 Apr 21, 2022
@KinoxKlark
Copy link
Member

Indeed, thanks for your help!

@KinoxKlark KinoxKlark added the release pending Merged but still needs official release label Apr 21, 2022
@Willy-JL Willy-JL deleted the fixes branch April 21, 2022 13:55
@KinoxKlark KinoxKlark removed the release pending Merged but still needs official release label Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants